Commit dadefe3b authored by Jesper Juhl's avatar Jesper Juhl Committed by Mauro Carvalho Chehab
Browse files

[media] gspca/stv06xx_pb0100: Don't potentially deref NULL in pb0100_start() 



usb_altnum_to_altsetting() may return NULL. If it does we'll dereference a
NULL pointer in
drivers/media/video/gspca/stv06xx/stv06xx_pb0100.c::pb0100_start().
As far as I can tell there's not really anything more sensible than
-ENODEV that we can return in that situation, but I'm not at all intimate
with this code so I'd like a bit of review/comments on this before it's
applied.
Anyway, here's a proposed patch.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Cc: Jean-Francois Moine <moinejf@free.fr>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Erik Andren <erik.andren@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 488ebc48

drivers/media/video/gspca/stv06xx/stv06xx_pb0100.c

+2 −0
Original line number Diff line number Diff line
@@ -217,6 +217,8 @@ static int pb0100_start(struct sd *sd) 


	intf = usb_ifnum_to_if(sd->gspca_dev.dev, sd->gspca_dev.iface);

	alt = usb_altnum_to_altsetting(intf, sd->gspca_dev.alt);

	if (!alt)

		return -ENODEV;

	packet_size = le16_to_cpu(alt->endpoint[0].desc.wMaxPacketSize);



	/* If we don't have enough bandwidth use a lower framerate */