Commit dc593fd4 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI/VGA: Remove empty vga_arb_device_card_gone() 

vga_arb_device_card_gone() has always been empty.  Remove it.

Link: https://lore.kernel.org/r/20220224224753.297579-9-helgaas@kernel.org


Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 37114e4d

drivers/pci/vgaarb.c

+1 −15
Original line number Diff line number Diff line
@@ -123,8 +123,6 @@ static int vga_str_to_iostate(char *buf, int str_size, int *io_state) 
/* this is only used a cookie - it should not be dereferenced */

static struct pci_dev *vga_default;



static void vga_arb_device_card_gone(struct pci_dev *pdev);



/* Find somebody in our list */

static struct vga_device *vgadev_find(struct pci_dev *pdev)

{
@@ -878,10 +876,6 @@ static bool vga_arbiter_del_pci_device(struct pci_dev *pdev) 
	/* Remove entry from list */

	list_del(&vgadev->list);

	vga_count--;

	/* Notify userland driver that the device is gone so it discards

	 * it's copies of the pci_dev pointer

	 */

	vga_arb_device_card_gone(pdev);



	/* Wake up all possible waiters */

	wake_up_all(&vga_wait_queue);
@@ -1131,9 +1125,7 @@ static ssize_t vga_arb_read(struct file *file, char __user *buf, 
	if (lbuf == NULL)

		return -ENOMEM;



	/* Shields against vga_arb_device_card_gone (pci_dev going

	 * away), and allows access to vga list

	 */

	/* Protects vga_list */

	spin_lock_irqsave(&vga_lock, flags);



	/* If we are targeting the default, use it */
@@ -1150,8 +1142,6 @@ static ssize_t vga_arb_read(struct file *file, char __user *buf, 
		/* Wow, it's not in the list, that shouldn't happen,

		 * let's fix us up and return invalid card

		 */

		if (pdev == priv->target)

			vga_arb_device_card_gone(pdev);

		spin_unlock_irqrestore(&vga_lock, flags);

		len = sprintf(lbuf, "invalid");

		goto done;
@@ -1495,10 +1485,6 @@ static int vga_arb_release(struct inode *inode, struct file *file) 
	return 0;

}



static void vga_arb_device_card_gone(struct pci_dev *pdev)

{

}



/*

 * callback any registered clients to let them know we have a

 * change in VGA cards