Commit dcb00ee8 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (max6621) Use HWMON_CHANNEL_INFO macro 



The HWMON_CHANNEL_INFO macro simplifies the code, reduces the likelihood
of errors, and makes the code easier to read.

The conversion was done automatically with coccinelle. The semantic patch
used to make this change is as follows.

@r@
initializer list elements;
identifier i;
@@

-u32 i[] = {
-  elements,
-  0
-};

@s@
identifier r.i,j,ty;
@@

-struct hwmon_channel_info j = {
-       .type = ty,
-       .config = i,
-};

@script:ocaml t@
ty << s.ty;
elements << r.elements;
shorter;
elems;
@@

shorter :=
   make_ident (List.hd(List.rev (Str.split (Str.regexp "_") ty)));
elems :=
   make_ident
    (String.concat ","
     (List.map (fun x -> Printf.sprintf "\n\t\t\t   %s" x)
       (Str.split (Str.regexp " , ") elements)))

@@
identifier s.j,t.shorter;
identifier t.elems;
@@

- &j
+ HWMON_CHANNEL_INFO(shorter,elems)

This patch does not introduce functional changes. Many thanks to
Julia Lawall for providing the semantic patch.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent b605e671

drivers/hwmon/max6621.c

+12 −30
Original line number Diff line number Diff line
@@ -458,17 +458,10 @@ static const struct regmap_config max6621_regmap_config = { 
	.num_reg_defaults = ARRAY_SIZE(max6621_regmap_default),

};



static u32 max6621_chip_config[] = {

	HWMON_C_REGISTER_TZ,

	0

};



static const struct hwmon_channel_info max6621_chip = {

	.type = hwmon_chip,

	.config = max6621_chip_config,

};



static const u32 max6621_temp_config[] = {

static const struct hwmon_channel_info *max6621_info[] = {

	HWMON_CHANNEL_INFO(chip,

			   HWMON_C_REGISTER_TZ),

	HWMON_CHANNEL_INFO(temp,

			   HWMON_T_INPUT | HWMON_T_LABEL | HWMON_T_OFFSET,

			   HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_CRIT_ALARM | HWMON_T_LABEL,

			   HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_CRIT_ALARM | HWMON_T_LABEL,
@@ -477,18 +470,7 @@ static const u32 max6621_temp_config[] = { 
			   HWMON_T_INPUT | HWMON_T_LABEL,

			   HWMON_T_INPUT | HWMON_T_LABEL,

			   HWMON_T_INPUT | HWMON_T_LABEL,

	HWMON_T_INPUT | HWMON_T_LABEL,

	0

};



static const struct hwmon_channel_info max6621_temp = {

	.type = hwmon_temp,

	.config = max6621_temp_config,

};



static const struct hwmon_channel_info *max6621_info[] = {

	&max6621_chip,

	&max6621_temp,

			   HWMON_T_INPUT | HWMON_T_LABEL),

	NULL

};