Commit dec6aa49 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

fbdev: sh_mobile_hdmi: modify flags name to more specific 



This patch solve below report from Guennadi

1)

> +/* Audio source select */
> +#define HDMI_SRC_MASK		(0xF << 0)
> +#define HDMI_SRC_I2S		(0 << 0) /* default */
> +#define HDMI_SRC_SPDIF		(1 << 0)
> +#define HDMI_SRC_DSD		(2 << 0)
> +#define HDMI_SRC_HBR		(3 << 0)

I would be more specific with these macro names, i.e., include "AUDIO" or
"SND" or something similar in them, e.g., HDMI_AUDIO_SRC_I2S.

2)

> +	case HDMI_SRC_I2S:
> +		data = (0x0 << 3);
> +		break;
> +	case HDMI_SRC_SPDIF:
> +		data = (0x1 << 3);
> +		break;
> +	case HDMI_SRC_DSD:
> +		data = (0x2 << 3);
> +		break;
> +	case HDMI_SRC_HBR:
> +		data = (0x3 << 3);

In all above cases parenthesis are superfluous.

Reported-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent f4363b7d

drivers/video/sh_mobile_hdmi.c

+9 −9
Original line number Diff line number Diff line
@@ -389,20 +389,20 @@ static void sh_hdmi_audio_config(struct sh_hdmi *hdmi) 
	 * [6:5] set required down sampling rate if required

	 * [4:3] set required audio source

	 */

	switch (pdata->flags & HDMI_SRC_MASK) {

	switch (pdata->flags & HDMI_SND_SRC_MASK) {

	default:

		/* fall through */

	case HDMI_SRC_I2S:

		data = (0x0 << 3);

	case HDMI_SND_SRC_I2S:

		data = 0x0 << 3;

		break;

	case HDMI_SRC_SPDIF:

		data = (0x1 << 3);

	case HDMI_SND_SRC_SPDIF:

		data = 0x1 << 3;

		break;

	case HDMI_SRC_DSD:

		data = (0x2 << 3);

	case HDMI_SND_SRC_DSD:

		data = 0x2 << 3;

		break;

	case HDMI_SRC_HBR:

		data = (0x3 << 3);

	case HDMI_SND_SRC_HBR:

		data = 0x3 << 3;

		break;

	}

	hdmi_write(hdmi, data, HDMI_AUDIO_SETTING_1);

include/video/sh_mobile_hdmi.h

+5 −5
Original line number Diff line number Diff line
@@ -23,11 +23,11 @@ struct device; 
 */



/* Audio source select */

#define HDMI_SRC_MASK		(0xF << 0)

#define HDMI_SRC_I2S		(0 << 0) /* default */

#define HDMI_SRC_SPDIF		(1 << 0)

#define HDMI_SRC_DSD		(2 << 0)

#define HDMI_SRC_HBR		(3 << 0)

#define HDMI_SND_SRC_MASK	(0xF << 0)

#define HDMI_SND_SRC_I2S	(0 << 0) /* default */

#define HDMI_SND_SRC_SPDIF	(1 << 0)

#define HDMI_SND_SRC_DSD	(2 << 0)

#define HDMI_SND_SRC_HBR	(3 << 0)



struct sh_mobile_hdmi_info {

	struct sh_mobile_lcdc_chan_cfg	*lcd_chan;