Commit e0b212ec authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Mauro Carvalho Chehab
Browse files

media: tw686x: Fix memory leak in tw686x_video_init 



video_device_alloc() allocates memory for vdev,
when video_register_device() fails, it doesn't release the memory and
leads to memory leak, call video_device_release() to fix this.

Fixes: 704a84cc ("[media] media: Support Intersil/Techwell TW686x-based video capture cards")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 5b304046

drivers/media/pci/tw686x/tw686x-video.c

+3 −1
Original line number Diff line number Diff line
@@ -1280,8 +1280,10 @@ int tw686x_video_init(struct tw686x_dev *dev) 
		video_set_drvdata(vdev, vc);



		err = video_register_device(vdev, VFL_TYPE_VIDEO, -1);

		if (err < 0)

		if (err < 0) {

			video_device_release(vdev);

			goto error;

		}

		vc->num = vdev->num;

	}