Commit e13ca460 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Mauro Carvalho Chehab
Browse files

media: mediatek: vcodec: Skip SOURCE_CHANGE & EOS events for stateless 



The stateless decoder API does not specify the usage of SOURCE_CHANGE
and EOF events. These events are used by stateful decoders to signal
changes in the bitstream. They do not make sense for stateless decoders.

Do not handle subscription for these two types of events for stateless
decoder instances. This fixes the last v4l2-compliance error:

Control ioctls:
		fail: v4l2-test-controls.cpp(946): have_source_change || have_eos
	test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL

Fixes: 8cdc3794 ("media: mtk-vcodec: vdec: support stateless API")
Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarNicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 978bbc39

drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c

+5 −0
Original line number Diff line number Diff line
@@ -255,6 +255,11 @@ static int vidioc_vdec_querycap(struct file *file, void *priv, 
static int vidioc_vdec_subscribe_evt(struct v4l2_fh *fh,

				     const struct v4l2_event_subscription *sub)

{

	struct mtk_vcodec_ctx *ctx = fh_to_ctx(fh);



	if (ctx->dev->vdec_pdata->uses_stateless_api)

		return v4l2_ctrl_subscribe_event(fh, sub);



	switch (sub->type) {

	case V4L2_EVENT_EOS:

		return v4l2_event_subscribe(fh, sub, 2, NULL);