Commit e19c6bd4 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Benjamin Tissoires
Browse files

HID: cp2112: Use BIT() in GPIO setter and getter 



Use BIT() in GPIO setter and getter for the sake of consistency
with GENMASK() usage elsewhere in the driver.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230703185222.50554-10-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarBenjamin Tissoires <bentiss@kernel.org>
parent ee0682b0

drivers/hid/hid-cp2112.c

+2 −2
Original line number Diff line number Diff line
@@ -197,7 +197,7 @@ static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset) 
		goto exit;

	}



	buf[1] &= ~(1 << offset);

	buf[1] &= ~BIT(offset);

	buf[2] = gpio_push_pull;



	ret = hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf,
@@ -228,7 +228,7 @@ static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int value) 


	buf[0] = CP2112_GPIO_SET;

	buf[1] = value ? CP2112_GPIO_ALL_GPIO_MASK : 0;

	buf[2] = 1 << offset;

	buf[2] = BIT(offset);



	ret = hid_hw_raw_request(hdev, CP2112_GPIO_SET, buf,

				 CP2112_GPIO_SET_LENGTH, HID_FEATURE_REPORT,