Commit e1f8807a authored by Daniel W. S. Almeida's avatar Daniel W. S. Almeida Committed by Mauro Carvalho Chehab
Browse files

media: usb: dib0700_devices.c: remove useless if/else 

Fix the following coccinelle report:

drivers/media/usb/dvb-usb/dib0700_devices.c:1741:1-3:
WARNING: possible condition with no effect (if == else)

Both branches are the same, so remove the if/else altogether.

Found using - Coccinelle (http://coccinelle.lip6.fr

)

[hverkuil: fix checkpatch warnings]

Signed-off-by: default avatarDaniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 56149c8c

drivers/media/usb/dvb-usb/dib0700_devices.c

+3 −8
Original line number Diff line number Diff line
@@ -1738,14 +1738,9 @@ static int dib809x_tuner_attach(struct dvb_usb_adapter *adap) 
	struct dib0700_adapter_state *st = adap->priv;

	struct i2c_adapter *tun_i2c = st->dib8000_ops.get_i2c_master(adap->fe_adap[0].fe, DIBX000_I2C_INTERFACE_TUNER, 1);



	if (adap->id == 0) {

		if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c, &dib809x_dib0090_config) == NULL)

			return -ENODEV;

	} else {

		/* FIXME: check if it is fe_adap[1] */

		if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c, &dib809x_dib0090_config) == NULL)

	/* FIXME: if adap->id != 0, check if it is fe_adap[1] */

	if (!dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c, &dib809x_dib0090_config))

		return -ENODEV;

	}



	st->set_param_save = adap->fe_adap[0].fe->ops.tuner_ops.set_params;

	adap->fe_adap[0].fe->ops.tuner_ops.set_params = dib8096_set_param_override;