Commit e46ff78b authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: remove the last urb callback macros 



Both usb_read_port_complete and usb_write_port_complete have a regs
parameter that is not used.

When this parameter is removed, the functions can be used as urb
completion callbacks directly. There's no need for the macros that
strip the second parameter.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210408195601.4762-1-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eae92424

drivers/staging/rtl8188eu/include/usb_ops_linux.h

+0 −5
Original line number Diff line number Diff line
@@ -10,11 +10,6 @@ 
#define USB_HIGH_SPEED_BULK_SIZE	512

#define USB_FULL_SPEED_BULK_SIZE	64



#define usb_write_port_complete(purb, regs)		\

	usb_write_port_complete(purb)

#define usb_read_port_complete(purb, regs)		\

	usb_read_port_complete(purb)



unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr);



u8 usb_read8(struct adapter *adapter, u32 addr);

drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

+2 −2
Original line number Diff line number Diff line
@@ -334,7 +334,7 @@ u32 usb_read32(struct adapter *adapter, u32 addr) 
	return le32_to_cpu(data);

}



static void usb_read_port_complete(struct urb *purb, struct pt_regs *regs)

static void usb_read_port_complete(struct urb *purb)

{

	struct recv_buf *precvbuf = (struct recv_buf *)purb->context;

	struct adapter *adapt = (struct adapter *)precvbuf->adapter;
@@ -519,7 +519,7 @@ int usb_write32(struct adapter *adapter, u32 addr, u32 val) 
	return usbctrl_vendorreq(adapter, wvalue, &data, 4, REALTEK_USB_VENQT_WRITE);

}



static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs)

static void usb_write_port_complete(struct urb *purb)

{

	struct xmit_buf *pxmitbuf = (struct xmit_buf *)purb->context;

	struct adapter *padapter = pxmitbuf->padapter;