Commit e4e29079 authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf stat: Fix memory leak on error path 



strdup() is used to deduplicate, ensure it isn't leaking an already
created string by freeing first.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: John Garry <john.garry@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20211107085444.3781604-1-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 4e88118c

tools/perf/util/stat-shadow.c

+1 −0
Original line number Diff line number Diff line
@@ -444,6 +444,7 @@ void perf_stat__collect_metric_expr(struct evlist *evsel_list) 
						"Add %s event to groups to get metric expression for %s\n",

						metric_name,

						counter->name);

					free(printed);

					printed = strdup(metric_name);

				}

				invalid = true;