Commit e57655e6 authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: qcom-qmp-usb: disable runtime PM on unbind 



Make sure to disable runtime PM also on driver unbind.

Fixes: ac0d2399 ("phy: qcom-qmp: Add support for runtime PM").
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20220907110728.19092-10-johan+linaro@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6d07bd6f

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

+3 −4
Original line number Diff line number Diff line
@@ -2838,7 +2838,9 @@ static int qcom_qmp_phy_usb_probe(struct platform_device *pdev) 
		return -ENOMEM;



	pm_runtime_set_active(dev);

	pm_runtime_enable(dev);

	ret = devm_pm_runtime_enable(dev);

	if (ret)

		return ret;

	/*

	 * Prevent runtime pm from being ON by default. Users can enable

	 * it using power/control in sysfs.
@@ -2872,13 +2874,10 @@ static int qcom_qmp_phy_usb_probe(struct platform_device *pdev) 
	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);

	if (!IS_ERR(phy_provider))

		dev_info(dev, "Registered Qcom-QMP phy\n");

	else

		pm_runtime_disable(dev);



	return PTR_ERR_OR_ZERO(phy_provider);



err_node_put:

	pm_runtime_disable(dev);

	of_node_put(child);

	return ret;

}