Commit e6393818 authored by Colin Ian King's avatar Colin Ian King Committed by Bjorn Andersson
Browse files

soc: qcom: socinfo: Fix off-by-one array index bounds check 



There is an off-by-one array index bounds check on array
pmic_models. Fix this by checking using < rather than <= on
the array size.

Addresses-Coverity: ("Out-of-bounds read")
Fixes: 734c78e7 ("soc: qcom: socinfo: add info from PMIC models array")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210118113651.71955-1-colin.king@canonical.com


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 3bc4bf77

drivers/soc/qcom/socinfo.c

+1 −1
Original line number Diff line number Diff line
@@ -332,7 +332,7 @@ static int qcom_show_pmic_model_array(struct seq_file *seq, void *p) 
		unsigned int model = SOCINFO_MINOR(get_unaligned_le32(ptr + 2 * i * sizeof(u32)));

		unsigned int die_rev = get_unaligned_le32(ptr + (2 * i + 1) * sizeof(u32));



		if (model <= ARRAY_SIZE(pmic_models) && pmic_models[model])

		if (model < ARRAY_SIZE(pmic_models) && pmic_models[model])

			seq_printf(seq, "%s %u.%u\n", pmic_models[model],

				   SOCINFO_MAJOR(le32_to_cpu(die_rev)),

				   SOCINFO_MINOR(le32_to_cpu(die_rev)));