Commit e67d7f60 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman
Browse files

tty: gdm724x: simplify gdm_tty_write() 



len and remain can never be negative in gdm_tty_write(). So remove such
a check and move the check of remaining bytes to the loop condition.
This way, the preceding 'if' is now superfluous too. Fix all that and
make the code cleaner.

Signed-off-by: default avatarJiri Slaby (SUSE) <jirislaby@kernel.org>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: linux-staging@lists.linux.dev
Link: https://lore.kernel.org/r/20230810103900.19353-1-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c70fd7c0

drivers/staging/gdm724x/gdm_tty.c

+1 −6
Original line number Diff line number Diff line
@@ -158,10 +158,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len) 
	if (!gdm_tty_ready(gdm))

		return -ENODEV;



	if (!len)

		return 0;



	while (1) {

	while (remain) {

		size_t sending_len = min(MUX_TX_MAX_SIZE, remain);

		gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,

					(void *)(buf + sent_len),
@@ -171,8 +168,6 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len) 
					gdm);

		sent_len += sending_len;

		remain -= sending_len;

		if (remain <= 0)

			break;

	}



	return len;