Commit e716ad3c authored by Oded Gabbay's avatar Oded Gabbay
Browse files

habanalabs: make sure cs type is valid in cs_ioctl_signal_wait 



Although we get a valid cs type from the callee, in case new values
will be added in the future, it is best to check the expected values
in that function.

Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 3e622996

drivers/misc/habanalabs/common/command_submission.c

+3 −1
Original line number Diff line number Diff line
@@ -1068,9 +1068,11 @@ static int cs_ioctl_signal_wait(struct hl_fpriv *hpriv, enum hl_cs_type cs_type, 
	if (cs_type == CS_TYPE_WAIT || cs_type == CS_TYPE_SIGNAL)

		rc = cs_ioctl_signal_wait_create_jobs(hdev, ctx, cs, q_type,

				q_idx);

	else

	else if (cs_type == CS_TYPE_COLLECTIVE_WAIT)

		rc = hdev->asic_funcs->collective_wait_create_jobs(hdev, ctx,

				cs, q_idx, collective_engine_id);

	else

		rc = -EINVAL;



	if (rc)

		goto free_cs_object;