Commit e84cfa36 authored by ye xingchen's avatar ye xingchen Committed by Hans de Goede
Browse files

platform/x86/dell: alienware-wmi: Use sysfs_emit() instead of scnprintf() 



Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: default avatarye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212021721543696124@zte.com.cn


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent d240849c

drivers/platform/x86/dell/alienware-wmi.c

+16 −25
Original line number Diff line number Diff line
@@ -398,10 +398,10 @@ static ssize_t show_control_state(struct device *dev, 
				  struct device_attribute *attr, char *buf)

{

	if (lighting_control_state == LEGACY_BOOTING)

		return scnprintf(buf, PAGE_SIZE, "[booting] running suspend\n");

		return sysfs_emit(buf, "[booting] running suspend\n");

	else if (lighting_control_state == LEGACY_SUSPEND)

		return scnprintf(buf, PAGE_SIZE, "booting running [suspend]\n");

	return scnprintf(buf, PAGE_SIZE, "booting [running] suspend\n");

		return sysfs_emit(buf, "booting running [suspend]\n");

	return sysfs_emit(buf, "booting [running] suspend\n");

}



static ssize_t store_control_state(struct device *dev,
@@ -547,14 +547,12 @@ static ssize_t show_hdmi_cable(struct device *dev, 
				   (u32 *) &out_data);

	if (ACPI_SUCCESS(status)) {

		if (out_data == 0)

			return scnprintf(buf, PAGE_SIZE,

					 "[unconnected] connected unknown\n");

			return sysfs_emit(buf, "[unconnected] connected unknown\n");

		else if (out_data == 1)

			return scnprintf(buf, PAGE_SIZE,

					 "unconnected [connected] unknown\n");

			return sysfs_emit(buf, "unconnected [connected] unknown\n");

	}

	pr_err("alienware-wmi: unknown HDMI cable status: %d\n", status);

	return scnprintf(buf, PAGE_SIZE, "unconnected connected [unknown]\n");

	return sysfs_emit(buf, "unconnected connected [unknown]\n");

}



static ssize_t show_hdmi_source(struct device *dev,
@@ -571,14 +569,12 @@ static ssize_t show_hdmi_source(struct device *dev, 


	if (ACPI_SUCCESS(status)) {

		if (out_data == 1)

			return scnprintf(buf, PAGE_SIZE,

					 "[input] gpu unknown\n");

			return sysfs_emit(buf, "[input] gpu unknown\n");

		else if (out_data == 2)

			return scnprintf(buf, PAGE_SIZE,

					 "input [gpu] unknown\n");

			return sysfs_emit(buf, "input [gpu] unknown\n");

	}

	pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);

	return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");

	return sysfs_emit(buf, "input gpu [unknown]\n");

}



static ssize_t toggle_hdmi_source(struct device *dev,
@@ -652,14 +648,12 @@ static ssize_t show_amplifier_status(struct device *dev, 
				   (u32 *) &out_data);

	if (ACPI_SUCCESS(status)) {

		if (out_data == 0)

			return scnprintf(buf, PAGE_SIZE,

					 "[unconnected] connected unknown\n");

			return sysfs_emit(buf, "[unconnected] connected unknown\n");

		else if (out_data == 1)

			return scnprintf(buf, PAGE_SIZE,

					 "unconnected [connected] unknown\n");

			return sysfs_emit(buf, "unconnected [connected] unknown\n");

	}

	pr_err("alienware-wmi: unknown amplifier cable status: %d\n", status);

	return scnprintf(buf, PAGE_SIZE, "unconnected connected [unknown]\n");

	return sysfs_emit(buf, "unconnected connected [unknown]\n");

}



static DEVICE_ATTR(status, S_IRUGO, show_amplifier_status, NULL);
@@ -706,17 +700,14 @@ static ssize_t show_deepsleep_status(struct device *dev, 
					(u32 *) &out_data);

	if (ACPI_SUCCESS(status)) {

		if (out_data == 0)

			return scnprintf(buf, PAGE_SIZE,

					 "[disabled] s5 s5_s4\n");

			return sysfs_emit(buf, "[disabled] s5 s5_s4\n");

		else if (out_data == 1)

			return scnprintf(buf, PAGE_SIZE,

					 "disabled [s5] s5_s4\n");

			return sysfs_emit(buf, "disabled [s5] s5_s4\n");

		else if (out_data == 2)

			return scnprintf(buf, PAGE_SIZE,

					 "disabled s5 [s5_s4]\n");

			return sysfs_emit(buf, "disabled s5 [s5_s4]\n");

	}

	pr_err("alienware-wmi: unknown deep sleep status: %d\n", status);

	return scnprintf(buf, PAGE_SIZE, "disabled s5 s5_s4 [unknown]\n");

	return sysfs_emit(buf, "disabled s5 s5_s4 [unknown]\n");

}



static ssize_t toggle_deepsleep(struct device *dev,