Commit e84ee1a7 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Lee Jones
Browse files

mfd: asic3: Add missing iounmap() on error asic3_mfd_probe 



Add the missing iounmap() before return from asic3_mfd_probe
in the error handling case.

Fixes: 64e8867b ("mfd: tmio_mmc hardware abstraction for CNF area")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220307072947.5369-1-linmq006@gmail.com
parent e4f8e065

drivers/mfd/asic3.c

+7 −3
Original line number Diff line number Diff line
@@ -906,14 +906,14 @@ static int __init asic3_mfd_probe(struct platform_device *pdev, 
		ret = mfd_add_devices(&pdev->dev, pdev->id,

			&asic3_cell_ds1wm, 1, mem, asic->irq_base, NULL);

		if (ret < 0)

			goto out;

			goto out_unmap;

	}



	if (mem_sdio && (irq >= 0)) {

		ret = mfd_add_devices(&pdev->dev, pdev->id,

			&asic3_cell_mmc, 1, mem_sdio, irq, NULL);

		if (ret < 0)

			goto out;

			goto out_unmap;

	}



	ret = 0;
@@ -927,7 +927,11 @@ static int __init asic3_mfd_probe(struct platform_device *pdev, 
		ret = mfd_add_devices(&pdev->dev, 0,

			asic3_cell_leds, ASIC3_NUM_LEDS, NULL, 0, NULL);

	}

	return ret;



out_unmap:

	if (asic->tmio_cnf)

		iounmap(asic->tmio_cnf);

out:

	return ret;

}