Commit e90cfa81 authored by Bui Quang Minh's avatar Bui Quang Minh Committed by Greg Kroah-Hartman
Browse files

USB: dummy-hcd: Fix uninitialized array use in init() 



This error path

	err_add_pdata:
		for (i = 0; i < mod_data.num; i++)
			kfree(dum[i]);

can be triggered when not all dum's elements are initialized.

Fix this by initializing all dum's elements to NULL.

Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarBui Quang Minh <minhquangbui99@gmail.com>
Link: https://lore.kernel.org/r/1607063090-3426-1-git-send-email-minhquangbui99@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c7721e15

drivers/usb/gadget/udc/dummy_hcd.c

+1 −1
Original line number Diff line number Diff line
@@ -2738,7 +2738,7 @@ static int __init init(void) 
{

	int	retval = -ENOMEM;

	int	i;

	struct	dummy *dum[MAX_NUM_UDC];

	struct	dummy *dum[MAX_NUM_UDC] = {};



	if (usb_disabled())

		return -ENODEV;