Unverified Commit e930bea4 authored by Antoine Gennart's avatar Antoine Gennart Committed by Mark Brown
Browse files

ASoC: tlv320adc3xxx: BUG: Correct micbias setting 



The micbias setting for tlv320adc can also have the value '3' which
means that the micbias ouput pin is connected to the input pin AVDD.

Signed-off-by: default avatarAntoine Gennart <gennartan@disroot.org>
Link: https://lore.kernel.org/r/20230929130117.77661-1-gennartan@disroot.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 892fbdb2

sound/soc/codecs/tlv320adc3xxx.c

+2 −2
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ 
#define ADC3XXX_BYPASS_RPGA		0x80



/* MICBIAS control bits */

#define ADC3XXX_MICBIAS_MASK		0x2

#define ADC3XXX_MICBIAS_MASK		0x3

#define ADC3XXX_MICBIAS1_SHIFT		5

#define ADC3XXX_MICBIAS2_SHIFT		3
@@ -1099,7 +1099,7 @@ static int adc3xxx_parse_dt_micbias(struct adc3xxx *adc3xxx, 
	unsigned int val;



	if (!of_property_read_u32(np, propname, &val)) {

		if (val >= ADC3XXX_MICBIAS_AVDD) {

		if (val > ADC3XXX_MICBIAS_AVDD) {

			dev_err(dev, "Invalid property value for '%s'\n", propname);

			return -EINVAL;

		}