Commit e9668427 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Linus Walleij
Browse files

dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix matching pin config 



Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern
does not work as expected because of linux,phandle in the DTB:

  sm8350-hdk.dtb: pinctrl@f100000: qup-uart3-default-state: 'oneOf' conditional failed, one must be fixed:
    'pins' is a required property
    'function' is a required property
    'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+'
    [[59]] is not of type 'object'

Make the schema stricter and expect such nodes to be followed with a
'-pins' suffix.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220912061746.6311-17-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent d70f858f

Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml

+4 −3
Original line number Diff line number Diff line
@@ -44,8 +44,9 @@ patternProperties: 
    oneOf:

      - $ref: "#/$defs/qcom-sm8350-tlmm-state"

      - patternProperties:

          ".*":

          "-pins$":

            $ref: "#/$defs/qcom-sm8350-tlmm-state"

        additionalProperties: false



$defs:

  qcom-sm8350-tlmm-state:
@@ -130,13 +131,13 @@ examples: 
                };



                uart-w-subnodes-state {

                        rx {

                        rx-pins {

                                pins = "gpio18";

                                function = "qup3";

                                bias-pull-up;

                        };



                        tx {

                        tx-pins {

                                pins = "gpio19";

                                function = "qup3";

                                bias-disable;