Commit ea1cc585 authored by Fabio Aiuto's avatar Fabio Aiuto Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SDIO_TX_TASKLET 



remove conditional code blocks checked by unused
CONFIG_SDIO_TX_TASKLET

cleaning required in TODO file:

find and remove code blocks guarded by never set CONFIG_FOO defines

Signed-off-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/e7f5f364d9f1f6ab271841b203c4de6c82ecfc9f.1615801722.git.fabioaiuto83@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f2ee6fee

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

+0 −4
Original line number Diff line number Diff line
@@ -4431,19 +4431,16 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum HAL_DEF_VARIABLE variable, v 


void rtl8723b_start_thread(struct adapter *padapter)

{

#ifndef CONFIG_SDIO_TX_TASKLET

	struct xmit_priv *xmitpriv = &padapter->xmitpriv;



	xmitpriv->SdioXmitThread = kthread_run(rtl8723bs_xmit_thread, padapter, "RTWHALXT");

	if (IS_ERR(xmitpriv->SdioXmitThread)) {

		RT_TRACE(_module_hal_xmit_c_, _drv_err_, ("%s: start rtl8723bs_xmit_thread FAIL!!\n", __func__));

	}

#endif

}



void rtl8723b_stop_thread(struct adapter *padapter)

{

#ifndef CONFIG_SDIO_TX_TASKLET

	struct xmit_priv *xmitpriv = &padapter->xmitpriv;



	/*  stop xmit_buf_thread */
@@ -4452,5 +4449,4 @@ void rtl8723b_stop_thread(struct adapter *padapter) 
		wait_for_completion(&xmitpriv->SdioXmitTerminate);

		xmitpriv->SdioXmitThread = NULL;

	}

#endif

}

drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c

+0 −8
Original line number Diff line number Diff line
@@ -124,10 +124,6 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter) 
	/* pxmitbuf->priv_data = NULL; */

	rtw_free_xmitbuf(pxmitpriv, pxmitbuf);



#ifdef CONFIG_SDIO_TX_TASKLET

	tasklet_hi_schedule(&pxmitpriv->xmit_tasklet);

#endif



	return _FAIL;

}
@@ -601,11 +597,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( 


		pxmitpriv->tx_drop++;

	} else {

#ifdef CONFIG_SDIO_TX_TASKLET

		tasklet_hi_schedule(&pxmitpriv->xmit_tasklet);

#else

		complete(&pxmitpriv->SdioXmitStart);

#endif

	}



	return err;

drivers/staging/rtl8723bs/include/rtw_xmit.h

+0 −4
Original line number Diff line number Diff line
@@ -412,13 +412,9 @@ struct xmit_priv { 


	u8 wmm_para_seq[4];/* sequence for wmm ac parameter strength from large to small. it's value is 0->vo, 1->vi, 2->be, 3->bk. */



#ifdef CONFIG_SDIO_TX_TASKLET

	struct tasklet_struct xmit_tasklet;

#else

	void *SdioXmitThread;

	struct completion SdioXmitStart;

	struct completion SdioXmitTerminate;

#endif /* CONFIG_SDIO_TX_TASKLET */



	struct __queue free_xmitbuf_queue;

	struct __queue pending_xmitbuf_queue;