Commit eac859b8 authored by Kumar Kartikeya Dwivedi's avatar Kumar Kartikeya Dwivedi Committed by Greg Kroah-Hartman
Browse files

staging: emxx_udc: Make incorrectly defined global static 



The global gpio_desc pointer and int vbus_irq were defined in the header,
instead put the definitions in the translation unit and make them static as
there's only a single consumer, and these symbols shouldn't pollute the
global namespace.

This fixes the following sparse warnings for this driver:
drivers/staging/emxx_udc/emxx_udc.c: note: in included file:
drivers/staging/emxx_udc/emxx_udc.h:23:18: warning: symbol 'vbus_gpio' was not
declared. Should it be static?  drivers/staging/emxx_udc/emxx_udc.h:24:5:
warning: symbol 'vbus_irq' was not declared. Should it be static?

Signed-off-by: default avatarKumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20210207085911.270746-1-memxor@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f2d4eef5

drivers/staging/emxx_udc/emxx_udc.c

+3 −0
Original line number Diff line number Diff line
@@ -34,6 +34,9 @@ 
#define	DRIVER_DESC	"EMXX UDC driver"

#define	DMA_ADDR_INVALID	(~(dma_addr_t)0)



static struct gpio_desc *vbus_gpio;

static int vbus_irq;



static const char	driver_name[] = "emxx_udc";

static const char	driver_desc[] = DRIVER_DESC;

drivers/staging/emxx_udc/emxx_udc.h

+0 −2
Original line number Diff line number Diff line
@@ -20,8 +20,6 @@ 
/* below hacked up for staging integration */

#define GPIO_VBUS 0 /* GPIO_P153 on KZM9D */

#define INT_VBUS 0 /* IRQ for GPIO_P153 */

struct gpio_desc *vbus_gpio;

int vbus_irq;



/*------------ Board dependence(Wait) */