Commit eb01e81f authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: this endless loop is executed only once 



There's a funny "loop" in rtl8188eu_xmitframe_complete. It looks like

do {
  ... some commands...
  break;
} while (1);

Remove it.

Acked-by: default avatarMichael Straube <straube.linux@gmail.com>
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210908085747.32254-4-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent db4e963a

drivers/staging/r8188eu/hal/rtl8188eu_xmit.c

+15 −19
Original line number Diff line number Diff line
@@ -437,7 +437,6 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitp 
	}



	/* 3 1. pick up first frame */

	do {

	rtw_free_xmitframe(pxmitpriv, pxmitframe);



	pxmitframe = rtw_dequeue_xframe(pxmitpriv, pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry);
@@ -459,9 +458,6 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitp 
	/*  always return ndis_packet after rtw_xmitframe_coalesce */

	rtw_os_xmit_complete(adapt, pxmitframe);



		break;

	} while (1);



	/* 3 2. aggregate same priority and same DA(AP or STA) frames */

	pfirstframe = pxmitframe;

	len = xmitframe_need_length(pfirstframe) + TXDESC_SIZE + (pfirstframe->pkt_offset * PACKET_OFFSET_SZ);