Commit ec02dd23 authored by Timur Tabi's avatar Timur Tabi Committed by Florian Tobias Schandinat
Browse files

drivers/video: fsl-diu-fb: fix potential memcpy buffer overflow bug 



It makes no sense to limit the size of a strncpy() to the length of
the source string.

Signed-off-by: default avatarTimur Tabi <timur@freescale.com>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent f8c6bf6a

drivers/video/fsl-diu-fb.c

+1 −1
Original line number Diff line number Diff line
@@ -655,7 +655,7 @@ static void set_fix(struct fb_info *info) 
	struct fb_var_screeninfo *var = &info->var;

	struct mfb_info *mfbi = info->par;



	strncpy(fix->id, mfbi->id, strlen(mfbi->id));

	strncpy(fix->id, mfbi->id, sizeof(fix->id));

	fix->line_length = var->xres_virtual * var->bits_per_pixel / 8;

	fix->type = FB_TYPE_PACKED_PIXELS;

	fix->accel = FB_ACCEL_NONE;