Commit ec090a03 authored by Tudor Ambarus's avatar Tudor Ambarus Committed by Miquel Raynal
Browse files

mtd: core: Remove partid and partname debugfs files 



partid and partname debugfs files were used just by SPI NOR, but they were
replaced by sysfs entries. Since these debugfs files are no longer used in
mtd, remove dead code. The directory is kept as it is used by nandsim,
mtdswap and docg3.

Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: default avatarPratyush Yadav <p.yadav@ti.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220225144656.634682-1-tudor.ambarus@microchip.com
parent d9a16830

drivers/mtd/mtdcore.c

+1 −34
Original line number Diff line number Diff line
@@ -336,28 +336,6 @@ static const struct device_type mtd_devtype = { 
	.release	= mtd_release,

};



static int mtd_partid_debug_show(struct seq_file *s, void *p)

{

	struct mtd_info *mtd = s->private;



	seq_printf(s, "%s\n", mtd->dbg.partid);



	return 0;

}



DEFINE_SHOW_ATTRIBUTE(mtd_partid_debug);



static int mtd_partname_debug_show(struct seq_file *s, void *p)

{

	struct mtd_info *mtd = s->private;



	seq_printf(s, "%s\n", mtd->dbg.partname);



	return 0;

}



DEFINE_SHOW_ATTRIBUTE(mtd_partname_debug);



static bool mtd_expert_analysis_mode;



#ifdef CONFIG_DEBUG_FS
@@ -377,23 +355,12 @@ static struct dentry *dfs_dir_mtd; 


static void mtd_debugfs_populate(struct mtd_info *mtd)

{

	struct mtd_info *master = mtd_get_master(mtd);

	struct device *dev = &mtd->dev;

	struct dentry *root;



	if (IS_ERR_OR_NULL(dfs_dir_mtd))

		return;



	root = debugfs_create_dir(dev_name(dev), dfs_dir_mtd);

	mtd->dbg.dfs_dir = root;



	if (master->dbg.partid)

		debugfs_create_file("partid", 0400, root, master,

				    &mtd_partid_debug_fops);



	if (master->dbg.partname)

		debugfs_create_file("partname", 0400, root, master,

				    &mtd_partname_debug_fops);

	mtd->dbg.dfs_dir = debugfs_create_dir(dev_name(dev), dfs_dir_mtd);

}



#ifndef CONFIG_MMU

include/linux/mtd/mtd.h

+0 −3
Original line number Diff line number Diff line
@@ -188,9 +188,6 @@ struct module; /* only needed for owner field in mtd_info */ 
 */

struct mtd_debug_info {

	struct dentry *dfs_dir;



	const char *partname;

	const char *partid;

};



/**