Commit ec0b7e24 authored by Frank Rowand's avatar Frank Rowand Committed by Rob Herring
Browse files

of: add consistency check to of_node_release() 



Add an additional consistency check to of_node_release(), which is
called when the reference count of a devicetree node is decremented
to zero.  The node's children should have been deleted before the
node is deleted so check that no children exist.

Signed-off-by: default avatarFrank Rowand <frowand.list@gmail.com>
Link: https://lore.kernel.org/r/20230213185702.395776-7-frowand.list@gmail.com


Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 23522dd7

drivers/of/dynamic.c

+4 −0
Original line number Diff line number Diff line
@@ -377,6 +377,10 @@ void of_node_release(struct kobject *kobj) 
			       __func__, node);

	}



	if (node->child)

		pr_err("ERROR: %s() unexpected children for %pOF/%s\n",

			__func__, node->parent, node->full_name);



	property_list_free(node->properties);

	property_list_free(node->deadprops);

	fwnode_links_purge(of_fwnode_handle(node));