Commit ec1804da authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: atomisp: warn if mipi de-allocation failed 



There's a note at the uninit function that warns about issues
with mipi frames de-allocation. print a warning if the problem
ever happens.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent dc41f7df

drivers/staging/media/atomisp/pci/sh_css.c

+5 −1
Original line number Diff line number Diff line
@@ -20,6 +20,8 @@ 


#include "hmm.h"



#include "atomisp_internal.h"



#include "ia_css.h"

#include "sh_css_hrt.h"		/* only for file 2 MIPI */

#include "ia_css_buffer.h"
@@ -2286,7 +2288,9 @@ ia_css_uninit(void) 
	sh_css_params_free_default_gdc_lut();



	/* TODO: JB: implement decent check and handling of freeing mipi frames */

	//assert(ref_count_mipi_allocation == 0); //mipi frames are not freed

	if (!mipi_is_free())

		dev_warn(atomisp_dev, "mipi frames are not freed.\n");



	/* cleanup generic data */

	sh_css_params_uninit();

	ia_css_refcount_uninit();

drivers/staging/media/atomisp/pci/sh_css_mipi.c

+11 −0
Original line number Diff line number Diff line
@@ -261,6 +261,17 @@ mipi_init(void) 
		ref_count_mipi_allocation[i] = 0;

}



bool mipi_is_free(void)

{

	unsigned int i;



	for (i = 0; i < N_CSI_PORTS; i++)

		if (ref_count_mipi_allocation[i])

			return false;



	return true;

}



int

calculate_mipi_buff_size(

    struct ia_css_stream_config *stream_cfg,

drivers/staging/media/atomisp/pci/sh_css_mipi.h

+2 −0
Original line number Diff line number Diff line
@@ -23,6 +23,8 @@ 
void

mipi_init(void);



bool mipi_is_free(void);



int

allocate_mipi_frames(struct ia_css_pipe *pipe, struct ia_css_stream_info *info);