Commit ec9fb3c5 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Dave Hansen
Browse files

x86/apic/ipi: Code cleanup 



Remove completely useless and mindlessly copied comments and tidy up the
code which causes eye bleed when looking at it.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: default avatarMichael Kelley <mikelley@microsoft.com>
Tested-by: default avatarSohil Mehta <sohil.mehta@intel.com>
Tested-by: Juergen Gross <jgross@suse.com> # Xen PV (dom0 and unpriv. guest)
parent f2bb0b4f

arch/x86/kernel/apic/ipi.c

+7 −16
Original line number Diff line number Diff line
@@ -184,18 +184,13 @@ void default_send_IPI_single_phys(int cpu, int vector) 


void default_send_IPI_mask_sequence_phys(const struct cpumask *mask, int vector)

{

	unsigned long query_cpu;

	unsigned long flags;

	unsigned long cpu;



	/*

	 * Hack. The clustered APIC addressing mode doesn't allow us to send

	 * to an arbitrary mask, so I do a unicast to each CPU instead.

	 * - mbligh

	 */

	local_irq_save(flags);

	for_each_cpu(query_cpu, mask) {

	for_each_cpu(cpu, mask) {

		__default_send_IPI_dest_field(per_cpu(x86_cpu_to_apicid,

				query_cpu), vector, APIC_DEST_PHYSICAL);

				cpu), vector, APIC_DEST_PHYSICAL);

	}

	local_irq_restore(flags);

}
@@ -203,18 +198,15 @@ void default_send_IPI_mask_sequence_phys(const struct cpumask *mask, int vector) 
void default_send_IPI_mask_allbutself_phys(const struct cpumask *mask,

						 int vector)

{

	unsigned int this_cpu = smp_processor_id();

	unsigned int query_cpu;

	unsigned int cpu, this_cpu = smp_processor_id();

	unsigned long flags;



	/* See Hack comment above */



	local_irq_save(flags);

	for_each_cpu(query_cpu, mask) {

		if (query_cpu == this_cpu)

	for_each_cpu(cpu, mask) {

		if (cpu == this_cpu)

			continue;

		__default_send_IPI_dest_field(per_cpu(x86_cpu_to_apicid,

				 query_cpu), vector, APIC_DEST_PHYSICAL);

				 cpu), vector, APIC_DEST_PHYSICAL);

	}

	local_irq_restore(flags);

}
@@ -283,7 +275,6 @@ void default_send_IPI_mask_logical(const struct cpumask *cpumask, int vector) 
	local_irq_restore(flags);

}



/* must come after the send_IPI functions above for inlining */

static int convert_apicid_to_cpu(int apic_id)

{

	int i;