Commit ecab1e9a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: goldfishfb: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent e16e7ea4

drivers/video/fbdev/goldfishfb.c

+2 −3
Original line number Diff line number Diff line
@@ -283,7 +283,7 @@ static int goldfish_fb_probe(struct platform_device *pdev) 
	return ret;

}



static int goldfish_fb_remove(struct platform_device *pdev)

static void goldfish_fb_remove(struct platform_device *pdev)

{

	size_t framesize;

	struct goldfish_fb *fb = platform_get_drvdata(pdev);
@@ -296,7 +296,6 @@ static int goldfish_fb_remove(struct platform_device *pdev) 
						fb->fb.fix.smem_start);

	iounmap(fb->reg_base);

	kfree(fb);

	return 0;

}



static const struct of_device_id goldfish_fb_of_match[] = {
@@ -315,7 +314,7 @@ MODULE_DEVICE_TABLE(acpi, goldfish_fb_acpi_match); 


static struct platform_driver goldfish_fb_driver = {

	.probe		= goldfish_fb_probe,

	.remove		= goldfish_fb_remove,

	.remove_new	= goldfish_fb_remove,

	.driver = {

		.name = "goldfish_fb",

		.of_match_table = goldfish_fb_of_match,