Commit ecd5507e authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: qcom-qmp-pcie: add pcs_misc sanity check 



Make sure that the (otherwise) optional pcs_misc IO region has been
provided in case the configuration specifies a corresponding
initialisation table to avoid crashing with malformed device trees.

Note that the related debug message is now superfluous as the region is
only used when the configuration has a pcs_misc table.

Fixes: 421c9a0e ("phy: qcom: qmp: Add SDM845 PCIe QMP PHY support")
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20220916102340.11520-2-johan+linaro@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent b767dedc

drivers/phy/qualcomm/phy-qcom-qmp-pcie.c

+4 −2
Original line number Diff line number Diff line
@@ -2300,8 +2300,10 @@ static int qmp_pcie_create(struct device *dev, struct device_node *np, int id, 
	    of_device_is_compatible(dev->of_node, "qcom,ipq6018-qmp-pcie-phy"))

		qphy->pcs_misc = qphy->pcs + 0x400;



	if (!qphy->pcs_misc)

		dev_vdbg(dev, "PHY pcs_misc-reg not used\n");

	if (!qphy->pcs_misc) {

		if (cfg->pcs_misc_tbl || cfg->pcs_misc_tbl_sec)

			return -EINVAL;

	}



	qphy->pipe_clk = devm_get_clk_from_child(dev, np, NULL);

	if (IS_ERR(qphy->pipe_clk)) {