Commit ee1809ed authored by Jiaxun Yang's avatar Jiaxun Yang Committed by Thomas Bogendoerfer
Browse files

MIPS: fw: Allow firmware to pass a empty env 

fw_getenv will use env entry to determine style of env,
however it is legal for firmware to just pass a empty list.

Check if first entry exist before running strchr to avoid
null pointer dereference.

Cc: stable@vger.kernel.org
Link: https://github.com/clbr/n64bootloader/issues/5


Signed-off-by: default avatarJiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 7fb6f7b0

arch/mips/fw/lib/cmdline.c

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ char *fw_getenv(char *envname) 
{

	char *result = NULL;



	if (_fw_envp != NULL) {

	if (_fw_envp != NULL && fw_envp(0) != NULL) {

		/*

		 * Return a pointer to the given environment variable.

		 * YAMON uses "name", "value" pairs, while U-Boot uses