Commit ee522bcf authored by Yang Yingliang's avatar Yang Yingliang Committed by Pavel Machek
Browse files

leds: tlc591xx: fix return value check in tlc591xx_probe() 



After device_get_match_data(), tlc591xx is not checked, add
check for it and also check np after dev_of_node.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 6efb943b

drivers/leds/leds-tlc591xx.c

+6 −2
Original line number Diff line number Diff line
@@ -148,16 +148,20 @@ static int 
tlc591xx_probe(struct i2c_client *client,

	       const struct i2c_device_id *id)

{

	struct device_node *np = dev_of_node(&client->dev), *child;

	struct device_node *np, *child;

	struct device *dev = &client->dev;

	const struct tlc591xx *tlc591xx;

	struct tlc591xx_priv *priv;

	int err, count, reg;



	tlc591xx = device_get_match_data(dev);

	np = dev_of_node(dev);

	if (!np)

		return -ENODEV;



	tlc591xx = device_get_match_data(dev);

	if (!tlc591xx)

		return -ENODEV;



	count = of_get_available_child_count(np);

	if (!count || count > tlc591xx->max_leds)

		return -EINVAL;