Commit ee8dadd7 authored by Daniel Oakley's avatar Daniel Oakley Committed by Mauro Carvalho Chehab
Browse files

media: vimc: use data link entities enum to index the ent_config array 



Future additions to the ent_config[] could break the association between
the index of the struct vimc_ent_config entries in the ent_config[] array,
and the index defined by the enum proposed in the previous patch. Using
designated initializers solves this by linking the 2 together clearly in
code and prevents the array not reflecting the enum. There is no
functional change intended.

Suggested-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: default avatarDaniel Oakley <daniel.oakley@ideasonboard.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent f2e761fd

drivers/media/test-drivers/vimc/vimc-core.c

+11 −11
Original line number Diff line number Diff line
@@ -82,48 +82,48 @@ struct vimc_pipeline_config { 
 */



static struct vimc_ent_config ent_config[] = {

	{

	[SENSOR_A] = {

		.name = "Sensor A",

		.type = &vimc_sensor_type

	},

	{

	[SENSOR_B] = {

		.name = "Sensor B",

		.type = &vimc_sensor_type

	},

	{

	[DEBAYER_A] = {

		.name = "Debayer A",

		.type = &vimc_debayer_type

	},

	{

	[DEBAYER_B] = {

		.name = "Debayer B",

		.type = &vimc_debayer_type

	},

	{

	[RAW_CAPTURE_0] = {

		.name = "Raw Capture 0",

		.type = &vimc_capture_type

	},

	{

	[RAW_CAPTURE_1] = {

		.name = "Raw Capture 1",

		.type = &vimc_capture_type

	},

	{

	[RGB_YUV_INPUT] = {

		/* TODO: change this to vimc-input when it is implemented */

		.name = "RGB/YUV Input",

		.type = &vimc_sensor_type

	},

	{

	[SCALER] = {

		.name = "Scaler",

		.type = &vimc_scaler_type

	},

	{

	[RGB_YUV_CAPTURE] = {

		.name = "RGB/YUV Capture",

		.type = &vimc_capture_type

	},

	{

	[LENS_A] = {

		.name = "Lens A",

		.type = &vimc_lens_type

	},

	{

	[LENS_B] = {

		.name = "Lens B",

		.type = &vimc_lens_type

	},