Commit ef194140 authored by Rob Herring's avatar Rob Herring Committed by Greg Kroah-Hartman
Browse files

serial: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230310144727.1545630-1-robh@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 571079f5

drivers/tty/serial/imx.c

+1 −2
Original line number Diff line number Diff line
@@ -2264,8 +2264,7 @@ static int imx_uart_probe(struct platform_device *pdev) 
	if (of_get_property(np, "fsl,dte-mode", NULL))

		sport->dte_mode = 1;



	if (of_get_property(np, "rts-gpios", NULL))

		sport->have_rtsgpio = 1;

	sport->have_rtsgpio = of_property_present(np, "rts-gpios");



	if (of_get_property(np, "fsl,inverted-tx", NULL))

		sport->inverted_tx = 1;

drivers/tty/serial/sh-sci.c

+1 −1
Original line number Diff line number Diff line
@@ -1573,7 +1573,7 @@ static void sci_request_dma(struct uart_port *port) 
	 * Don't request a dma channel if no channel was specified

	 * in the device tree.

	 */

	if (!of_find_property(port->dev->of_node, "dmas", NULL))

	if (!of_property_present(port->dev->of_node, "dmas"))

		return;



	chan = sci_request_dma_chan(port, DMA_MEM_TO_DEV);

drivers/tty/serial/sunzilog.c

+2 −2
Original line number Diff line number Diff line
@@ -1403,7 +1403,7 @@ static int zs_probe(struct platform_device *op) 
	int keyboard_mouse = 0;

	int err;



	if (of_find_property(op->dev.of_node, "keyboard", NULL))

	if (of_property_present(op->dev.of_node, "keyboard"))

		keyboard_mouse = 1;



	/* uarts must come before keyboards/mice */
@@ -1553,7 +1553,7 @@ static int __init sunzilog_init(void) 


	for_each_node_by_name(dp, "zs") {

		num_sunzilog++;

		if (of_find_property(dp, "keyboard", NULL))

		if (of_property_present(dp, "keyboard"))

			num_keybms++;

	}