Commit ef5d2056 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Staging: bcm: return -EFAULT on copy_to_user() errors 



bcm/InterfaceDld.c had a couple places which returned the number of
bytes remaining instead of -EFAULT.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent acedadfa

drivers/staging/bcm/InterfaceDld.c

+2 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static int bcm_download_config_file(PMINI_ADAPTER Adapter, 
	{

		bcm_kfree (Adapter->pstargetparams);

		Adapter->pstargetparams = NULL;

		return retval;

		return -EFAULT;

	}

	/* Parse the structure and then Download the Firmware */

	beceem_parse_target_struct(Adapter);
@@ -385,6 +385,7 @@ int bcm_ioctl_fw_download(PMINI_ADAPTER Adapter, FIRMWARE_INFO *psFwInfo) 
		if(retval != STATUS_SUCCESS)

		{

			BCM_DEBUG_PRINT(Adapter,DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "copying buffer from user space failed");

			retval = -EFAULT;

			goto error ;

		}