Commit ef73dcaa authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Michael Ellerman
Browse files

powerpc: xmon: remove unused variables 



Randconfig testing with W=1 showed up these warnings that I'd like to enable
by default:

arch/powerpc/xmon/xmon.c: In function 'dump_tlb_book3e':
arch/powerpc/xmon/xmon.c:3833:42: error: variable 'lrat' set but not used [-Werror=unused-but-set-variable]
 3833 |  int i, tlb, ntlbs, pidsz, lpidsz, rasz, lrat = 0;
      |                                          ^~~~
arch/powerpc/xmon/xmon.c:3831:23: error: variable 'lpidmask' set but not used [-Werror=unused-but-set-variable]
 3831 |  u32 mmucfg, pidmask, lpidmask;
      |                       ^~~~~~~~
arch/powerpc/xmon/xmon.c:3831:14: error: variable 'pidmask' set but not used [-Werror=unused-but-set-variable]
 3831 |  u32 mmucfg, pidmask, lpidmask;
      |              ^~~~~~~

Just remove these as they have been unused since the code was added in 2010.

Fixes: 03247157 ("powerpc/book3e: Add TLB dump in xmon for Book3E")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230809131024.2039647-2-arnd@kernel.org
parent 0f7ce21a

arch/powerpc/xmon/xmon.c

+2 −6
Original line number Diff line number Diff line
@@ -3828,9 +3828,9 @@ static void dump_tlb_44x(void) 
#ifdef CONFIG_PPC_BOOK3E_64

static void dump_tlb_book3e(void)

{

	u32 mmucfg, pidmask, lpidmask;

	u32 mmucfg;

	u64 ramask;

	int i, tlb, ntlbs, pidsz, lpidsz, rasz, lrat = 0;

	int i, tlb, ntlbs, pidsz, lpidsz, rasz;

	int mmu_version;

	static const char *pgsz_names[] = {

		"  1K",
@@ -3874,12 +3874,8 @@ static void dump_tlb_book3e(void) 
	pidsz = ((mmucfg >> 6) & 0x1f) + 1;

	lpidsz = (mmucfg >> 24) & 0xf;

	rasz = (mmucfg >> 16) & 0x7f;

	if ((mmu_version > 1) && (mmucfg & 0x10000))

		lrat = 1;

	printf("Book3E MMU MAV=%d.0,%d TLBs,%d-bit PID,%d-bit LPID,%d-bit RA\n",

	       mmu_version, ntlbs, pidsz, lpidsz, rasz);

	pidmask = (1ul << pidsz) - 1;

	lpidmask = (1ul << lpidsz) - 1;

	ramask = (1ull << rasz) - 1;



	for (tlb = 0; tlb < ntlbs; tlb++) {