Commit ef9385fb authored by Zhen Lei's avatar Zhen Lei Committed by Linus Walleij
Browse files

pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe() 



When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Acked-by: default avatarRay Jui <ray.jui@broadcom.com>
Link: https://lore.kernel.org/r/20210511085126.4287-1-thunder.leizhen@huawei.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 0f9facdb

drivers/pinctrl/bcm/pinctrl-iproc-gpio.c

+1 −3
Original line number Diff line number Diff line
@@ -813,10 +813,8 @@ static int iproc_gpio_probe(struct platform_device *pdev) 
	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);

	if (res) {

		chip->io_ctrl = devm_ioremap_resource(dev, res);

		if (IS_ERR(chip->io_ctrl)) {

			dev_err(dev, "unable to map I/O memory\n");

		if (IS_ERR(chip->io_ctrl))

			return PTR_ERR(chip->io_ctrl);

		}

		if (of_device_is_compatible(dev->of_node,

					    "brcm,cygnus-ccm-gpio"))

			io_ctrl_type = IOCTRL_TYPE_CDRU;