Commit effa7dde authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Jens Axboe
Browse files

gfs2: use __bio_add_page for adding single page to bio 



The GFS2 superblock reading code uses bio_add_page() to add a page to a
newly created bio. bio_add_page() can fail, but the return value is never
checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/087c67d4e4973f949d3519c1e4822784ce583c5a.1685532726.git.johannes.thumshirn@wdc.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2896db17

fs/gfs2/ops_fstype.c

+1 −1
Original line number Diff line number Diff line
@@ -254,7 +254,7 @@ static int gfs2_read_super(struct gfs2_sbd *sdp, sector_t sector, int silent) 


	bio = bio_alloc(sb->s_bdev, 1, REQ_OP_READ | REQ_META, GFP_NOFS);

	bio->bi_iter.bi_sector = sector * (sb->s_blocksize >> 9);

	bio_add_page(bio, page, PAGE_SIZE, 0);

	__bio_add_page(bio, page, PAGE_SIZE, 0);



	bio->bi_end_io = end_bio_io_page;

	bio->bi_private = page;