Unverified Commit f2b41b74 authored by Yang Yingliang's avatar Yang Yingliang Committed by Mark Brown
Browse files

regulator: core: fix unbalanced of node refcount in regulator_dev_lookup() 



I got the the following report:

  OF: ERROR: memory leak, expected refcount 1 instead of 2,
  of_node_get()/of_node_put() unbalanced - destroy cset entry:
  attach overlay node /i2c/pmic@62/regulators/exten

In of_get_regulator(), the node is returned from of_parse_phandle()
with refcount incremented, after using it, of_node_put() need be called.

Fixes: 69511a45 ("regulator: map consumer regulator based on device tree")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221115091508.900752-1-yangyingliang@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 91016037

drivers/regulator/core.c

+1 −0
Original line number Diff line number Diff line
@@ -1943,6 +1943,7 @@ static struct regulator_dev *regulator_dev_lookup(struct device *dev, 
		node = of_get_regulator(dev, supply);

		if (node) {

			r = of_find_regulator_by_node(node);

			of_node_put(node);

			if (r)

				return r;