Commit f54cad25 authored by Zou Wei's avatar Zou Wei Committed by Arnaldo Carvalho de Melo
Browse files

perf srccode: Use list_move() instead of equivalent list_del() + list_add() sequence 



Using list_move() instead of list_del() + list_add(), shorter,
equivalent.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZou Wei <zou_wei@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/1623113566-49455-1-git-send-email-zou_wei@huawei.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent f4f1c429

tools/perf/util/srccode.c

+1 −2
Original line number Diff line number Diff line
@@ -97,8 +97,7 @@ static struct srcfile *find_srcfile(char *fn) 
	hlist_for_each_entry (h, &srcfile_htab[hval], hash_nd) {

		if (!strcmp(fn, h->fn)) {

			/* Move to front */

			list_del(&h->nd);

			list_add(&h->nd, &srcfile_list);

			list_move(&h->nd, &srcfile_list);

			return h;

		}

	}