Unverified Commit f54f9b00 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

spi: bcmbca-hsspi: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20230303172041.2103336-14-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8c26432e

drivers/spi/spi-bcmbca-hsspi.c

+2 −4
Original line number Diff line number Diff line
@@ -576,7 +576,7 @@ static int bcmbca_hsspi_probe(struct platform_device *pdev) 
	return ret;

}



static int bcmbca_hsspi_remove(struct platform_device *pdev)

static void bcmbca_hsspi_remove(struct platform_device *pdev)

{

	struct spi_master *master = platform_get_drvdata(pdev);

	struct bcmbca_hsspi *bs = spi_master_get_devdata(master);
@@ -586,8 +586,6 @@ static int bcmbca_hsspi_remove(struct platform_device *pdev) 
	clk_disable_unprepare(bs->pll_clk);

	clk_disable_unprepare(bs->clk);

	sysfs_remove_group(&pdev->dev.kobj, &bcmbca_hsspi_group);



	return 0;

}



#ifdef CONFIG_PM_SLEEP
@@ -644,7 +642,7 @@ static struct platform_driver bcmbca_hsspi_driver = { 
		   .of_match_table = bcmbca_hsspi_of_match,

		   },

	.probe = bcmbca_hsspi_probe,

	.remove = bcmbca_hsspi_remove,

	.remove_new = bcmbca_hsspi_remove,

};



module_platform_driver(bcmbca_hsspi_driver);