Commit f785c541 authored by Christian Göttsche's avatar Christian Göttsche Committed by Paul Moore
Browse files

selinux: avoid avtab overflows 



Prevent inserting more than the supported U32_MAX number of entries.

Signed-off-by: default avatarChristian Göttsche <cgzones@googlemail.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent bbea03f4

security/selinux/ss/avtab.c

+2 −2
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ static int avtab_insert(struct avtab *h, const struct avtab_key *key, 
	struct avtab_node *prev, *cur, *newnode;

	u16 specified = key->specified & ~(AVTAB_ENABLED|AVTAB_ENABLED_OLD);



	if (!h || !h->nslot)

	if (!h || !h->nslot || h->nel == U32_MAX)

		return -EINVAL;



	hvalue = avtab_hash(key, h->mask);
@@ -156,7 +156,7 @@ struct avtab_node *avtab_insert_nonunique(struct avtab *h, 
	struct avtab_node *prev, *cur;

	u16 specified = key->specified & ~(AVTAB_ENABLED|AVTAB_ENABLED_OLD);



	if (!h || !h->nslot)

	if (!h || !h->nslot || h->nel == U32_MAX)

		return NULL;

	hvalue = avtab_hash(key, h->mask);

	for (prev = NULL, cur = h->htable[hvalue];