Commit f7cae626 authored by Lv Yunlong's avatar Lv Yunlong Committed by Herbert Xu
Browse files

crypto: qat - Fix a double free in adf_create_ring 



In adf_create_ring, if the callee adf_init_ring() failed, the callee will
free the ring->base_addr by dma_free_coherent() and return -EFAULT. Then
adf_create_ring will goto err and the ring->base_addr will be freed again
in adf_cleanup_ring().

My patch sets ring->base_addr to NULL after the first freed to avoid the
double free.

Fixes: a672a9dc ("crypto: qat - Intel(R) QAT transport code")
Signed-off-by: default avatarLv Yunlong <lyl2019@mail.ustc.edu.cn>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 556b64b9

drivers/crypto/qat/qat_common/adf_transport.c

+1 −0
Original line number Diff line number Diff line
@@ -172,6 +172,7 @@ static int adf_init_ring(struct adf_etr_ring_data *ring) 
		dev_err(&GET_DEV(accel_dev), "Ring address not aligned\n");

		dma_free_coherent(&GET_DEV(accel_dev), ring_size_bytes,

				  ring->base_addr, ring->dma_addr);

		ring->base_addr = NULL;

		return -EFAULT;

	}