Commit f8960ee7 authored Feb 11, 2010 by Julia Lawall Committed by Mauro Carvalho Chehab May 18, 2010

V4L/DVB: drivers/staging/tm6000/tm6000-video.c: correct NULL test

Test the just-allocated value for NULL rather than some other value.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x,y;
statement S;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) == NULL) S
|
if (
-   y
+   x
       == NULL)
 S
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 29ec15e9

drivers/staging/tm6000/tm6000-video.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -644,7 +644,7 @@ static int tm6000_prepare_isoc(struct tm6000_core *dev, unsigned int framesize)

		dev->isoc_ctl.transfer_buffer = kmalloc(sizeof(void )num_bufs,
		GFP_KERNEL);
		if (!dev->isoc_ctl.urb) {
		if (!dev->isoc_ctl.transfer_buffer) {
		tm6000_err("cannot allocate memory for usbtransfer\n");
		kfree(dev->isoc_ctl.urb);
		return -ENOMEM;