Commit f9061f4e authored by Daniel Lezcano's avatar Daniel Lezcano Committed by Daniel Lezcano
Browse files

thermal/of: Remove of_thermal_is_trip_valid() 



There is no benefit with the of_thermal_is_trip_valid() function as it
does the check the thermal_zone_get_trip() is already doing for the
sake of getting the trip point.

As all the calls have been replaced by thermal_zone_get_trip(), there
is no more users of of_thermal_is_trip_valid().

Remove the function.

Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20221003092602.1323944-18-daniel.lezcano@linaro.org
parent 2480b02a

drivers/thermal/thermal_core.h

+0 −10
Original line number Diff line number Diff line
@@ -139,16 +139,6 @@ thermal_cooling_device_stats_update(struct thermal_cooling_device *cdev, 
#endif /* CONFIG_THERMAL_STATISTICS */



/* device tree support */

#ifdef CONFIG_THERMAL_OF

bool of_thermal_is_trip_valid(struct thermal_zone_device *, int);

#else

static inline bool of_thermal_is_trip_valid(struct thermal_zone_device *tz,

					    int trip)

{

	return false;

}

#endif



int thermal_zone_device_is_enabled(struct thermal_zone_device *tz);



#endif /* __THERMAL_CORE_H__ */

drivers/thermal/thermal_of.c

+0 −19
Original line number Diff line number Diff line
@@ -19,25 +19,6 @@ 


#include "thermal_core.h"



/**

 * of_thermal_is_trip_valid - function to check if trip point is valid

 *

 * @tz:	pointer to a thermal zone

 * @trip:	trip point to evaluate

 *

 * This function is responsible for checking if passed trip point is valid

 *

 * Return: true if trip point is valid, false otherwise

 */

bool of_thermal_is_trip_valid(struct thermal_zone_device *tz, int trip)

{

	if (trip >= tz->num_trips || trip < 0)

		return false;



	return true;

}

EXPORT_SYMBOL_GPL(of_thermal_is_trip_valid);



static int of_thermal_set_trip_hyst(struct thermal_zone_device *tz, int trip,

				    int hyst)

{