Commit fa0048a4 authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Dmitry Baryshkov
Browse files

drm/msm/dp: Free resources after unregistering them 



The DP component's unbind operation walks through the submodules to
unregister and clean things up. But if the unbind happens because the DP
controller itself is being removed, all the memory for those submodules
has just been freed.

Change the order of these operations to avoid the many use-after-free
that otherwise happens in this code path.

Fixes: c943b494 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: default avatarBjorn Andersson <quic_bjorande@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/542166/
Link: https://lore.kernel.org/r/20230612220259.1884381-1-quic_bjorande@quicinc.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent a7bfb2ad

drivers/gpu/drm/msm/dp/dp_display.c

+1 −1
Original line number Diff line number Diff line
@@ -1300,9 +1300,9 @@ static int dp_display_remove(struct platform_device *pdev) 
{

	struct dp_display_private *dp = dev_get_dp_display_private(&pdev->dev);



	component_del(&pdev->dev, &dp_display_comp_ops);

	dp_display_deinit_sub_modules(dp);



	component_del(&pdev->dev, &dp_display_comp_ops);

	platform_set_drvdata(pdev, NULL);



	return 0;