Unverified Commit fac33cb5 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: Intel: Skylake: simplify S3 resume flows 



Commit cce6c149 ("ASoC: Intel: Skylake: add link management")
added a perfectly logical/symmetrical link handling for
'suspend_active' aka S0ix

However that commit also added a less obvious part, where during S3
resume the code will "turn off the links which are off before suspend"
as well as stop the cmd_io which is not started.

This sequence looks completely unnecessary and possibly wrong, remove it.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221017204946.207986-2-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a474dce8

sound/soc/intel/skylake/skl.c

+0 −9
Original line number Diff line number Diff line
@@ -387,15 +387,6 @@ static int skl_resume(struct device *dev) 
			snd_hdac_bus_init_cmd_io(bus);

	} else {

		ret = _skl_resume(bus);



		/* turn off the links which are off before suspend */

		list_for_each_entry(hlink, &bus->hlink_list, list) {

			if (!hlink->ref_count)

				snd_hdac_ext_bus_link_power_down(hlink);

		}



		if (!bus->cmd_dma_state)

			snd_hdac_bus_stop_cmd_io(bus);

	}



	return ret;