Commit fb59a920 authored by Aurabindo Pillai's avatar Aurabindo Pillai Committed by Alex Deucher
Browse files

drm/amd/display: add dummy PG callback for beige goby 



[Why&How]
PG registers are absent in beige goby, so programming these registers
generate call trace. Fix this by adding a dummy function in dcn303
initialization function which prevents writing to non existant registers.

Fixes: cd6d421e ("drm/amd/display: Initial DC support for Beige Goby")
Signed-off-by: default avatarAurabindo Pillai <aurabindo.pillai@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ac3fbe3b

drivers/gpu/drm/amd/display/dc/dcn303/dcn303_hwseq.c

+5 −0
Original line number Diff line number Diff line
@@ -38,3 +38,8 @@ void dcn303_dsc_pg_control(struct dce_hwseq *hws, unsigned int dsc_inst, bool po 
{

	/*DCN303 removes PG registers*/

}



void dcn303_enable_power_gating_plane(struct dce_hwseq *hws, bool enable)

{

	/*DCN303 removes PG registers*/

}

drivers/gpu/drm/amd/display/dc/dcn303/dcn303_hwseq.h

+1 −0
Original line number Diff line number Diff line
@@ -13,5 +13,6 @@ 
void dcn303_dpp_pg_control(struct dce_hwseq *hws, unsigned int dpp_inst, bool power_on);

void dcn303_hubp_pg_control(struct dce_hwseq *hws, unsigned int hubp_inst, bool power_on);

void dcn303_dsc_pg_control(struct dce_hwseq *hws, unsigned int dsc_inst, bool power_on);

void dcn303_enable_power_gating_plane(struct dce_hwseq *hws, bool enable);



#endif /* __DC_HWSS_DCN303_H__ */

drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c

+1 −0
Original line number Diff line number Diff line
@@ -16,4 +16,5 @@ void dcn303_hw_sequencer_construct(struct dc *dc) 
	dc->hwseq->funcs.dpp_pg_control = dcn303_dpp_pg_control;

	dc->hwseq->funcs.hubp_pg_control = dcn303_hubp_pg_control;

	dc->hwseq->funcs.dsc_pg_control = dcn303_dsc_pg_control;

	dc->hwseq->funcs.enable_power_gating_plane = dcn303_enable_power_gating_plane;

}