Commit fb8eaeb7 authored by Palmer Cox's avatar Palmer Cox Committed by Rafael J. Wysocki
Browse files

cpupower tools: Fix minor warnings 



Fix minor warnings reported with GCC 4.6:
* The sysfs_write_file function is unused - remove it.
* The pr_mon_len in the print_header function is unsed - remove it.

Signed-off-by: default avatarPalmer Cox <p@lmercox.com>
Signed-off-by: default avatarThomas Renninger <trenn@suse.de>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 275a4dc4

tools/power/cpupower/utils/helpers/sysfs.c

+0 −19
Original line number Diff line number Diff line
@@ -37,25 +37,6 @@ unsigned int sysfs_read_file(const char *path, char *buf, size_t buflen) 
	return (unsigned int) numread;

}



static unsigned int sysfs_write_file(const char *path,

				     const char *value, size_t len)

{

	int fd;

	ssize_t numwrite;



	fd = open(path, O_WRONLY);

	if (fd == -1)

		return 0;



	numwrite = write(fd, value, len);

	if (numwrite < 1) {

		close(fd);

		return 0;

	}

	close(fd);

	return (unsigned int) numwrite;

}



/*

 * Detect whether a CPU is online

 *

tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c

+1 −2
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ int fill_string_with_spaces(char *s, int n) 
void print_header(int topology_depth)

{

	int unsigned mon;

	int state, need_len, pr_mon_len;

	int state, need_len;

	cstate_t s;

	char buf[128] = "";

	int percent_width = 4;
@@ -93,7 +93,6 @@ void print_header(int topology_depth) 
	printf("%s|", buf);



	for (mon = 0; mon < avail_monitors; mon++) {

		pr_mon_len = 0;

		need_len = monitors[mon]->hw_states_num * (percent_width + 3)

			- 1;

		if (mon != 0) {