Commit fc187a46 authored by Li Yang's avatar Li Yang Committed by Geert Uytterhoeven
Browse files

soc: renesas: renesas-soc: Release 'chipid' from ioremap() 



Smatch reports:

drivers/soc/renesas/renesas-soc.c:536 renesas_soc_init() warn:
'chipid' from ioremap() not released on lines: 475.

If soc_dev_atrr allocation is failed, function renesas_soc_init()
will return without releasing 'chipid' from ioremap().

Fix this by adding function iounmap().

Fixes: cb5508e4 ("soc: renesas: Add support for reading product revision for RZ/G2L family")
Signed-off-by: default avatarLi Yang <lidaxian@hust.edu.cn>
Reviewed-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230331095545.31823-1-lidaxian@hust.edu.cn


Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent 1e135922

drivers/soc/renesas/renesas-soc.c

+4 −1
Original line number Diff line number Diff line
@@ -469,8 +469,11 @@ static int __init renesas_soc_init(void) 
	}



	soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL);

	if (!soc_dev_attr)

	if (!soc_dev_attr) {

		if (chipid)

			iounmap(chipid);

		return -ENOMEM;

	}



	np = of_find_node_by_path("/");

	of_property_read_string(np, "model", &soc_dev_attr->machine);