Commit fdf84f9a authored by Brian Norris's avatar Brian Norris Committed by Tzung-Bi Shih
Browse files

platform/chrome: cros_ec_lpc: Move mec_init to device probe 



Disregarding the weird global state hiding in this cros_ec_lpc_mec_*()
stuff, it belongs in device probe. We shouldn't assume we can access
hardware resources when the device isn't attached to the driver.

Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20221101152132.v2.1.I0728421299079b104710c202d5d7095b2674fd8c@changeid
parent 58f23a67

drivers/platform/chrome/cros_ec_lpc.c

+3 −3
Original line number Diff line number Diff line
@@ -354,6 +354,9 @@ static int cros_ec_lpc_probe(struct platform_device *pdev) 
		return -EBUSY;

	}



	cros_ec_lpc_mec_init(EC_HOST_CMD_REGION0,

			     EC_LPC_ADDR_MEMMAP + EC_MEMMAP_SIZE);



	/*

	 * Read the mapped ID twice, the first one is assuming the

	 * EC is a Microchip Embedded Controller (MEC) variant, if the
@@ -586,9 +589,6 @@ static int __init cros_ec_lpc_init(void) 
		return -ENODEV;

	}



	cros_ec_lpc_mec_init(EC_HOST_CMD_REGION0,

			     EC_LPC_ADDR_MEMMAP + EC_MEMMAP_SIZE);



	/* Register the driver */

	ret = platform_driver_register(&cros_ec_lpc_driver);

	if (ret) {